Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented profile selection #96

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gmiranda
Copy link

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@vox-pupuli-tasks
Copy link

Dear @gmiranda, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @gmiranda, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Should fix Travis CI checks
@jwyker
Copy link

jwyker commented Jun 20, 2022

@gmiranda - is there any any way to resolve the code conflicts?

@stiltr
Copy link

stiltr commented Jun 27, 2024

I know this is super old, but is there any chance of getting this merged?

@yakatz
Copy link

yakatz commented Jun 28, 2024

I know this is super old, but is there any chance of getting this merged?

If someone fixes the merge conflicts and tests

@yakatz
Copy link

yakatz commented Jun 28, 2024

Closing and reopening to trigger the tests

Edit: it actually looks like there aren't automated tests running on github. I'll try to take a closer look at this over the weekend.

@yakatz yakatz closed this Jun 28, 2024
@yakatz yakatz reopened this Jun 28, 2024
@yakatz
Copy link

yakatz commented Jun 28, 2024

This will need a bit of work, including new tests for the new parameter.

@gmiranda Are you still interested in getting this merged?

Otherwise, would someone else like to rebase and write tests (and open a new PR based on this one)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants